Exécute l'export Metabase depuis PHP #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1116 +/- ##
=========================================
Coverage 98.88% 98.88%
- Complexity 1822 1829 +7
=========================================
Files 364 366 +2
Lines 7873 7900 +27
=========================================
+ Hits 7785 7812 +27
Misses 88 88 ☔ View full report in Codecov by Sentry. |
florimondmanca
force-pushed
the
refactor/metabase-from-php
branch
3 times, most recently
from
c05f7d4 to
cfd174a
Compare
|
ℹ️ Je retravaille le code pour mieux le structurer selon l'archi DDD / hexa habituelle, je vais faire un StatisticsRepository, mettre la requête pour les utilisateurs actifs dans le UserRepository, etc. |
florimondmanca
force-pushed
the
refactor/metabase-from-php
branch
from
d17e97c to
f8468dd
Compare
florimondmanca
changed the title
florimondmanca
force-pushed
the
refactor/metabase-from-php
branch
2 times, most recently
from
6ab98e0 to
40ffcbf
Compare
|
Voilà, prêt pour une review je pense, @mmarchois (et @Lealefoulon si jamais tu veux jeter un oeil) |
florimondmanca
force-pushed
the
refactor/metabase-from-php
branch
from
40ffcbf to
65fc39f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Pour les besoins de #1110 et #1111, on va avoir besoin de requêter les exports DATEX et CIFS, ce qui est bien plus facile si l'export Metabase est lancé depuis PHP.
Cette PR préliminaire fait donc les changements suivants:
StatisticsRepository, qui lui même appelle des repository, par ex leUserRepositorypour les infos sur la date de dernière activitéTODO